Revert "explorer: fix halo cutoff over terrain (disableDepthTestDistance)" (#181)#183
Merged
rdhyee merged 1 commit intoisamplesorg:mainfrom May 9, 2026
Merged
Conversation
…t on points (isamplesorg#181)" This reverts commit d681758.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #181 (
d681758).Reported behavior:${\textsf{terrible}}$ — disabling depth test on point primitives caused regressions worse than the original halo crescents. Rolling back so prod returns to post-#180 state while we have Codex review d681758 and propose a corrected fix.
Original issue (still open): halos added in #180 expose terrain depth-test occlusion as crescents on hilly land, and at close zoom the dots vanish entirely.
Next steps:
d681758to identify a fix that doesn't regress whatever this just regressedRefs #178, #180.
🤖 Generated with Claude Code